[BUG] Fix Key Override includes #13831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
force-pushed
the
fix/key_overrides
branch
from
b50cdac
to
964351f
Compare
zvecr
requested changes
Aug 1, 2021
There was a problem hiding this comment.
I would rather keep the includes the same, and just do the following,
diff --git a/quantum/process_keycode/process_key_override.c b/quantum/process_keycode/process_key_override.c
index 8b45a9404..09b272507 100644
--- a/quantum/process_keycode/process_key_override.c
+++ b/quantum/process_keycode/process_key_override.c
@@ -18,7 +18,7 @@
#include "quantum.h"
#include "report.h"
#include "timer.h"
-#include "process_key_override_private.h"
+#include "process_key_override.h"
#include <debug.h>
|
I can do so, but is there a specific reason for doing so? quantum.h contains all of other includes, and this does need a good number of includes. Also, just this would work too: #include "process_key_override.h"
#include "quantum.h" |
|
Including the bare minimum is general best practice, and things like quantum.h including the world produces many assumptions that are harder to unpick later. As the consumer of the api, why would you need to care about another enabled feature like maybe audio. |
zvecr
approved these changes
Aug 1, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* [BUG] Fix Key Override includes * simplify includes
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* [BUG] Fix Key Override includes * simplify includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include was wrong. Fixed.
Types of Changes
Issues Fixed or Closed by This PR
Checklist